Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 19, 2025

  • SC/PEP Delegate has formally accepted/rejected the PEP and posted to the Discussions-To thread
  • Pull request title in appropriate format (PEP 123: Mark as Accepted)
  • Status changed to Accepted/Rejected
  • Resolution field points directly to SC/PEP Delegate official acceptance/rejected post, including the date (e.g. `01-Jan-2000 <https://discuss.python.org/t/12345/100>`__)
  • Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments
  • Discussions-To, Post-History and Python-Version up to date

@adqm @edemaine

We forgot to mark this as accepted.

I added the modification required by the SC at https://discuss.python.org/t/pep-798-unpacking-in-comprehensions/99435/60 as a note.

Perhaps just the first paragraph is enough?


📚 Documentation preview 📚: https://pep-previews--4753.org.readthedocs.build/

@adqm
Copy link
Contributor

adqm commented Dec 19, 2025

Thanks @hugovk! I was actually going to put in a PR for this (and for the actual implementation) this weekend, so the timing is perfect 🙂

If you think it works just to add this clarifying paragraph at the top, that seems fine to me. My updated version instead rewrites the relevant portions of the PEP, but I'm not sure which approach is preferable.

@hugovk
Copy link
Member Author

hugovk commented Dec 19, 2025

I don't mind which way, let's ask @JelleZijlstra.

@JelleZijlstra
Copy link
Member

I'd prefer changing the main text. It will be confusing for future readers of the PEP if the text of the PEP claims something different than the implementation.

@hugovk
Copy link
Member Author

hugovk commented Dec 22, 2025

Sounds good.

@adqm Would you like to open your own PR? Then we can close this one.

@adqm
Copy link
Contributor

adqm commented Dec 22, 2025

@hugovk Sure thing! I'll make another pass through my local changes and put in a PR, probably tomorrow morning.

@adqm
Copy link
Contributor

adqm commented Dec 23, 2025

@hugovk I just opened #4758, so I think this PR can be closed and we can continue discussion there. Thanks!

@hugovk hugovk closed this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants